Orebfuscator icon indicating copy to clipboard operation
Orebfuscator copied to clipboard

Visible fake-gen ores on the surface and in caves on Chunk boundaries

Open ProgrammerDan opened this issue 7 years ago • 16 comments

As reported here: https://www.spigotmc.org/threads/orebfuscator.145252/page-10#post-2394534

and explained / illustrated here: https://www.spigotmc.org/threads/orebfuscator.145252/page-10#post-2395414

ProgrammerDan avatar May 21 '17 16:05 ProgrammerDan

I know about this problem and even tried to solve it, but this ended not very good when we tested it for 50+ players. Last time I tried to reload chunks once their neighbors were loaded by server, but my implementation was very performance expensive. I think you remember we had a performance problem for Orebfuscator on Dev 3.0 lunch.

Ok, I will start thinking about the problem and how better to solve it :)

Aleksey-Terzi avatar May 22 '17 16:05 Aleksey-Terzi

RIGHT, I forgot about that. Thanks, feel free to PM me / bounce ideas

ProgrammerDan avatar May 22 '17 16:05 ProgrammerDan

I've been noticing this a lot on my server too, and players have been complaining about it. At first I thought it was random, but after seeing this I checked the places it appears in, and they were all chunk boundaries.

I use mode 2 so that at least players can tell when orbfuscator is lying to them, but maybe I should use mode 1 so they just see stone and don't complain ...

jacob1 avatar Jun 18 '17 22:06 jacob1

i agree with jacob1, i also had noticed this problem on my server with mode 2, also players complained about it. And i also thing about using the mode 1 maybe so the player just see a stone instead of fake orbs :3

CloudeLecaw avatar Jun 26 '17 10:06 CloudeLecaw

i did what cloudleclaw did aswell. it turns out tho that it obfuscated visible ores as stone now aswell thus making them invisible :/ i didnt remember having that many issues with fake blocks tho, it worked better for me on 4.3.0 than 4.3.3

melinstagibson avatar Aug 21 '17 14:08 melinstagibson

As a mitigation, you could try only obfuscating blocks that are below a certain y coordinate (this is the case for paper's antixray, which is configurable, though it's based on chunk sections instead of exact y coordinate).

RoboMWM avatar Oct 21 '17 05:10 RoboMWM

I'm supposing this message was addresses to me.

Thank for suggestion, but I don't think this really will solve problem (but at the same time perhaps would be good to have this option), because of most of walls with "fake blocks" are in the caves - where we should do obfuscation.

Problem happens because of problem how to obfuscate edge blocks when adjacent chunk is not loaded. I'm doing assumption that adjacent block from "non-loaded" chunk is solid and therefore if edge blocks from other sides is covered by solid blocks - it will be obfuscated.

If render distance on server is large - this issue almost never happen, and it will happen more often with smaller render distance. My last try to solve it by re-sending chunks when adjacent chunks loaded - failed, because of it lowered TPS for server with large amount of players.

Aleksey-Terzi avatar Oct 21 '17 06:10 Aleksey-Terzi

Same problem..

And good performance :(

Raphy123 avatar Oct 21 '17 07:10 Raphy123

I think issue is fixed now. Either wait for new release or recompile it by yourself from this fork: https://github.com/DevotedMC/Orebfuscator/

Aleksey-Terzi avatar Oct 25 '17 03:10 Aleksey-Terzi

Thanks !When did you think the next update ?

Raphy123 avatar Oct 25 '17 08:10 Raphy123

I'm not sure, but if you wish you can use my compilation: https://www.dropbox.com/s/tho7si3qg3fmr11/orebfuscator-4.3.4-SNAPSHOT.jar?dl=0

Would be nice to hear if it solved issue for you.

Aleksey-Terzi avatar Oct 25 '17 08:10 Aleksey-Terzi

Should be in a position to release this weekend at the latest, maybe sooner

ProgrammerDan avatar Oct 25 '17 16:10 ProgrammerDan

Hi Aleksey-Terzi. I tried the provided snapshot, but thereafter encountered hard crashes every few hours.

alexander-q avatar Jan 05 '18 00:01 alexander-q

@Aleksey-Terzi I have used your fork, but it sill not working https://prnt.sc/iaksab

Foorcee avatar Feb 05 '18 20:02 Foorcee

Any news ? My players are going insane.

NiyahVE avatar Feb 19 '18 23:02 NiyahVE

My players are going insane.

Use mode 1 for now then.

RoboMWM avatar Feb 20 '18 04:02 RoboMWM