isotp-c icon indicating copy to clipboard operation
isotp-c copied to clipboard

conformity on isotp_user.h

Open woodz- opened this issue 3 years ago • 5 comments

To be able to compile with C++ compilers, it's common practice to offer extern "C" on a makro basis. All C-based system includes of Linux do so. I suggest to do it likewise here.

Another thing is to #include <stdint.h>. The problem is that some compilers often automatically export names defined in various headers or provided types before such standards were in place. Details can be found here: https://stackoverflow.com/questions/11069108/uint32-t-does-not-name-a-type

woodz- avatar Feb 25 '22 11:02 woodz-

It seems this repo doesn't get much attention from its author any more. I'd be glad to include your change in my fork though, if you don't mind.

SimonCahill avatar Sep 01 '22 12:09 SimonCahill

Sure

woodz- avatar Sep 17 '22 16:09 woodz-

Branches have been merged

SimonCahill avatar Oct 10 '22 07:10 SimonCahill

great, have you got a link to your fork?

woodz- avatar Oct 13 '22 21:10 woodz-

https://github.com/SimonCahill/isotp-c <-- right there

SimonCahill avatar Oct 13 '22 21:10 SimonCahill