z-engine icon indicating copy to clipboard operation
z-engine copied to clipboard

Is this package still supported?

Open Rastusik opened this issue 3 years ago • 5 comments

Hey @lisachenko , is this package still supported? Does it make sense to create a pull request with php 8.1 support?

Rastusik avatar Oct 04 '22 16:10 Rastusik

Hello, @Rastusik! I'm not actively working on OSS projects right now, but if you want to work on this - I can give you maintainer permissions on this project, or can review and merge your PRs to enable 8.1/8.2 repos.

lisachenko avatar Oct 10 '22 18:10 lisachenko

@lisachenko that sounds great! I'm not really planning to be a real maintainer, but I can make contributions for PHP 8/8.1/8.2 support. If you think it's ok to give me maintainer permissions, I won't object, but I'm only planning to do work related to this: https://github.com/pixelfederation/swoole-bundle/blob/coroutines/docs/configuration-reference.md#additional-info-for-coroutines-usage . Which essentially is just support for newer php versions (with working tests of course). I won't have time for anything more.

Btw FYI even tests for PHP 8.0 are failing, I fixed them in my fork here: https://github.com/pixelfederation/z-engine/commits/8.0_fixes

Rastusik avatar Oct 11 '22 10:10 Rastusik