Lisa Liu-Thorrold

I can't understand what the purpose of this check is, or in actual fact what is actually being checked. How is the direction determined based solely on ips without context/history,...

Bulk calculations incorrect

1

``` public void updateFlowBulk (BasicPacketInfo packet){ if(this.src == packet.getSrc()){ updateForwardBulk(packet,blastBulkTS); }else { updateBackwardBulk(packet,flastBulkTS); } } ``` The src/dest values are byte arrays. This is a memory address comparison that will...

Down/up ratio calculation incorrect

1

`if(this.forward.size() > 0){ return (double)(this.backward.size()/this.forward.size()); } return 0; }` This is casting the result of an integer division (int/int) [which returns an int] to a float, rather than correctly casting...

**Describe the bug** There is some confusion about `domain_label_colname` in `tabletshift/core/features.py`. What is it's purpose, and how is it different from `domain_split_varname`? Is there a reason it is not added...

Hi, I node some inconsistencies, particular with the Hyperparameter selection in B5: chrome-extension://efaidnbmnnnibpcajpcglclefindmkaj/https://openreview.net/attachment?id=aExAsh1UHZo&name=supplementary_material which mentions specific values for lambda zero and lambda one. According to loss.py (line 70,71). it seems...