browser icon indicating copy to clipboard operation
browser copied to clipboard

Add flash plugin support

Open PoisonousJohn opened this issue 8 years ago • 5 comments

Flash is not working now

PoisonousJohn avatar Jan 12 '17 11:01 PoisonousJohn

QtWebEngine supports Flash. See http://doc.qt.io/qt-5/qtwebengine-features.html#pepper-flash-player-plugin-support. Haven't tested it yet, though.

timsueberkrueb avatar Jan 12 '17 16:01 timsueberkrueb

Flash is really bad regarding security and stability, unfortunately some sites are still using it, the most notable being Facebook. Of course we should support Flash but it should be disabled by default.

plfiorini avatar Jan 12 '17 17:01 plfiorini

I tried to add

Qt += webenginewidgets

and

QWebEngineSettings::defaultSettings()->setAttribute(QWebEngineSettings::PluginsEnabled, true)

and it's not working for me when I'm checking it here https://www.adobe.com/software/flash/about/

PoisonousJohn avatar Jan 12 '17 18:01 PoisonousJohn

@JohnPoison cool. We will need to handle it in a Oxide-compatible way (e.g. Qt += webenginewidgets only if QTWEBENGINE_ENABLED, same with the attribute). I agree with @plfiorini it should be disabled by default.

timsueberkrueb avatar Jan 12 '17 18:01 timsueberkrueb

Sure, it was just for test. I also agree that it should be disabled by default . But the problem is that it's not working and I can't understand why. Flash in DemoBrowser from Qt examples works on adobe test page. Yet it doesn't work on http://rutube.ru

PoisonousJohn avatar Jan 12 '17 18:01 PoisonousJohn