liquidaty
liquidaty
@julianz- I can reliably reproduce both errors, but this is in the context of proprietary code so it may take me a while to come up with code to reproduce...
@julianz- > why did you remove the line that sets n to 0 In the changes I made, that line became moot: either the loop is short-circuited via `continue`, an...
OK thanks for the response. We will fork it ourselves and start a separate repo. Before doing so, just wanted to confirm: you did see that all the code needed...
I would propose at least *allowing* a limit to be imposed if desired, rather than just doing away with it altogether. Ideally as a run-time option, but at the very...
Possibly this failure has nothing to do with the actual code changes. Here is what the log says: ``` C:\msys64\usr\bin\bash -lc "pacman-key --verify msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig" ==> Checking msys2-keyring-r21.b39fb11-1-any.pkg.tar.xz.sig... gpg: no valid...
@nicowilliams @wader @itchyny I think it's worth further dividing the target use cases / proposals into sub-scopes, given that the arguments for and against may be different for each. 1....
@itchyny I think it is a great idea to target well-defined specifications. Re json5, the immediate impact with of that, with respect to this particular issue, is that `#` would...
OK this PR has been updated and now covers the following: - C- and C++-style comments (but not `#` comments) are stripped - this behavior is only enabled when a...
> @liquidaty ah, do please get rid of the merge commit [...] If you don't know how to get rid of it I could walk you through it, or I...
> Will this PR be going to 1.7? We need more discussions on this topic > probably best to wait till after 1.7 to integrate this @itchyny @nicowilliams: regarding the...