liqo
liqo copied to clipboard
liqotech
auth.config.portOverride not being used by the service template
I noticed that the liqo-auth-service.yaml template is not using the auth.config.portOverride annotation, so when I override it, it does nothing. I think this is easily solvable, as it seems an error in the template
Hi @Fevereiro6, I think you misunderstood the meaning of that value. As explained in the documentation, you have to use it only if you are behind a NAT or a proxy.
A typical usage of it is in a scenario where you do not have a load balancer that provides a public IP. In this case, you can expose the auth and gateway services using a NodePort service and a NAT (configuring port-forwarding). This setup allows you to access liqo auth or gateway using the NAT IP but the liqo-auth needs to know which address has to be contacted from outside to reach itself. That's why you need to override it with the helm values.
I hope I have been clear, whether or not you can ask for more details.
@Fevereiro6 Feel free to make you contribution also with respect to the documentation, eg a PR to clarify this point, if you like.
Hi @Fevereiro6, I think you misunderstood the meaning of that value. As explained in the documentation, you have to use it only if you are behind a NAT or a proxy.
A typical usage of it is in a scenario where you do not have a load balancer that provides a public IP. In this case, you can expose the auth and gateway services using a NodePort service and a NAT (configuring port-forwarding). This setup allows you to access liqo auth or gateway using the NAT IP but the liqo-auth needs to know which address has to be contacted from outside to reach itself. That's why you need to override it with the helm values.
I hope I have been clear, whether or not you can ask for more details.
If I only have one public IP and I need to share it across Loadbalancer type services, I would need to override the port of liqo-auth, as the port (443) is the same as my other service. The override value is not used by any field, at least from what I saw.
Other option for my issue would be exposing liqo-auth via ingress which I tried but was not able to do it successfully
@Fevereiro6 I understand your use case. If you want to add settings in our helm chart to set a custom port for our load balancer feel free to do it.
@cheina97 I would keep this issue open for our future reference.
I believe that the term we used in values.yaml is misleading; I would suggest to rename that value from addressOverride/portOverride to addressExternal/portExternal, which looks more intuitive to me.
@aleoli any thought?