liqo icon indicating copy to clipboard operation
liqo copied to clipboard

Foreign cluster resource: enforce peering type

Open giorio94 opened this issue 2 years ago • 3 comments

Description

This PR introduces an "immutable" PeeringType field as part of the ForeignCluster API, in order to explicit the type of peering and prevent switching from one to another, which would cause potential issues. This also enables a better UX through liqoctl.

Fixes #(issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [ ] Existing tests
  • [ ] Manual testing

giorio94 avatar Sep 22 '22 13:09 giorio94

Hi @giorio94. Thanks for your PR!

I am @adamjensenbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: :boom: Breaking Change
  • kind/feature: :rocket: New Feature
  • kind/bug: :bug: Bug Fix
  • kind/cleanup: :broom: Code Refactoring
  • kind/docs: :memo: Documentation

adamjensenbot avatar Sep 22 '22 13:09 adamjensenbot

/build

giorio94 avatar Sep 22 '22 13:09 giorio94

/build

giorio94 avatar Sep 22 '22 13:09 giorio94

/test

giorio94 avatar Sep 27 '22 13:09 giorio94

/rebase test=true

giorio94 avatar Sep 29 '22 13:09 giorio94

/merge

giorio94 avatar Sep 29 '22 14:09 giorio94