liqo icon indicating copy to clipboard operation
liqo copied to clipboard

Bump ginkgo to v2 and convert legacy tests

Open giorio94 opened this issue 2 years ago • 5 comments

Description

This PR bumps ginkgo to the latest version, and converts a legacy test (another helper package is entirely removed, as practically no used).

Fixes #(issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [x] Automated tests

giorio94 avatar Aug 05 '22 09:08 giorio94

Hi @giorio94. Thanks for your PR!

I am @adamjensenbot. You can interact with me issuing a slash command in the first line of a comment. Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: :boom: Breaking Change
  • kind/feature: :rocket: New Feature
  • kind/bug: :bug: Bug Fix
  • kind/cleanup: :broom: Code Refactoring
  • kind/docs: :memo: Documentation

adamjensenbot avatar Aug 05 '22 09:08 adamjensenbot

/test

giorio94 avatar Aug 05 '22 09:08 giorio94

/test

giorio94 avatar Aug 05 '22 14:08 giorio94

/test

giorio94 avatar Aug 08 '22 08:08 giorio94

/test

giorio94 avatar Aug 08 '22 12:08 giorio94

/rebase test=true

giorio94 avatar Aug 16 '22 17:08 giorio94

/rebase test=true

giorio94 avatar Aug 17 '22 11:08 giorio94

/merge

giorio94 avatar Aug 17 '22 12:08 giorio94