adhocracy4 icon indicating copy to clipboard operation
adhocracy4 copied to clipboard

Poll refactor required

Open philli-m opened this issue 2 years ago • 3 comments

React 16 update has exposed issues with state handling in the PollQuestion component. UseEffect seems to be used only for errors or unchecking, unchecking should not be required if we used checked state correctly. Component has lots of repeat code and is very complex, possible solution to dumb down the question comps and do more in the questions list comp

Screenshot?

philli-m avatar Jan 17 '23 17:01 philli-m

btw @TeaJayyy @goapunk @CarolingerSeilchenspringer

hom3mad3 avatar Jun 26 '24 15:06 hom3mad3

@hom3mad3 So the way that interpret it, this means that the code of PollQuestion is in itself not optimal and needs to be revised before we think about changing certain aspects of the poll module, right?

t-j-q avatar Jun 27 '24 08:06 t-j-q

@hom3mad3 So the way that interpret it, this means that the code of PollQuestion is in itself not optimal and needs to be revised before we think about changing certain aspects of the poll module, right?

The entire poll needs refactoring. This includes not just the PollQuestion component, but all the other components that are dependencies of Poll as well.

hom3mad3 avatar Jun 27 '24 08:06 hom3mad3