adhocracy3 icon indicating copy to clipboard operation
adhocracy3 copied to clipboard

Pool search at depth one but SearchQuery defaults to depth zero

Open pallix opened this issue 10 years ago • 6 comments

I think it's super confusing that pool search at depth 1 by default:

https://github.com/liqd/adhocracy3.mercator/blob/406345f084c7fd05d7c82f6479deb8c9123c2542/src/adhocracy_core/adhocracy_core/sheets/pool.py#L45

but the search_query has an infinite depth (depth is zero).

pallix avatar May 18 '15 17:05 pallix

This caused the #1140 bug when refactoring a migration script and omitting the depth.

pallix avatar May 18 '15 17:05 pallix

I propose to set the default to inifite in both cases, we should ask the fronten team if this makes any trouble.

joka avatar Jun 01 '15 08:06 joka

I don't expect issues. @nidico what about you?

xi avatar Jun 01 '15 08:06 xi

I'm fine with infinite depth by default if this makes no difference performance-wise in the backend.

nidico avatar Jun 01 '15 09:06 nidico

I'm fine with infinite depth by default if this makes no difference performance-wise in the back

we need to test this

joka avatar Jun 02 '15 08:06 joka

I would also be fine with a depth of 1 everywhere.

xi avatar Sep 14 '16 10:09 xi