adhocracy-plus icon indicating copy to clipboard operation
adhocracy-plus copied to clipboard

Fix #2341: Replace liqd/django-autoslug dependency to upstream

Open DubeySandeep opened this issue 1 year ago • 4 comments

Overview

This PR fixes #2341 by replacing the forked/edited django-autoslug (introduced via #2188) with its original upstream.

This is possible now as the changes made on the forked repo are merged and released upstream.

Manual testing

Able to install the latest upstream django-autoslug via pip image

Able to run the server with the latest version of django-autoslug image

DubeySandeep avatar May 26 '23 16:05 DubeySandeep

Hey @DubeySandeep, thanks for your PRs and contributions! We are currently discussing internally whether we should have a CLA for external contributors. We probably shouldn't have one as it makes contributing harder but as this is a team decision it will still take us some time and I would like to wait until then before we merge this, sorry!

goapunk avatar May 31 '23 07:05 goapunk

@goapunk Thanks for the review and the heads-up! I think it's a good idea to have a CLA (assuming t will be a simple form (max 3 inputs)), I'm fine with signing the CLA, let me know once you have an update! :)

Also, it looks like we are using a secret (secret.COV) which is not permissible to forked PRs build (ref), resulting into empty string value for the token and blocking my PR build to complete the Coveralls check.

Possible solutions:

  • Use secrets.GITHUB_TOKEN similar to line 92 (Note: I don't have context for the usage of COV secret and whether it can be replaced by secrets.GITHUB_TOKEN)
  • Use pull_request_target event as suggested in the doc.

DubeySandeep avatar Jun 07 '23 11:06 DubeySandeep

Hi @goapunk, I wanted to check whether you have any updates on the CLA requirements.

DubeySandeep avatar Jun 13 '23 14:06 DubeySandeep

Hi @DubeySandeep, sorry for the late reply and thanks again for your contribution. We should have something ready by the end of the week. We'll also look into fixing the CI/Coveralls for external PRs, thanks for reporting the issue and the suggestions!

goapunk avatar Jun 20 '23 08:06 goapunk

superseded by https://github.com/liqd/adhocracy-plus/pull/2710

goapunk avatar Jun 17 '24 13:06 goapunk