a4-opin
a4-opin copied to clipboard
Info block horizontal Picture is to high
URL: https://opin-dev.liqd.net/de/ambassadors/ user: admin expected behaviour: Picture should be in Inline with the headline behaviour: Picture is higher than the headline, so if more than one info block vertical is there it is too close to each block and the Link button is cut off important screensize: device & browser: Comment/Question:
Screenshot?
@phillimorland are these two issues? That the bottom is cut off and that the blocks are too close or that the picture is too high?
@hello-kathi ok so the headline thing is actually an accessibility thing. The info blocks should be self contained information and should therefore have h2 headlines always, never h1 as they do not describe the page content and not h3 as they should be used within the block for sub headings, does that make sense?
here is a link to describe how headings should be used https://accessibility.iu.edu/creating-content/web-content/headings.html
Link being cut off is a different issue
@phillimorland No not really. I cant change the headline/Title in the infoblock that is a fix box in wagtail. But maybe I wrote it wrong: The Picture from the horizontal infoblock with no colour background (boxed, boxed variant) is ditching on the block above. The picture is not in the middle of the text block. Thats whats bother me, the headline can stay how it is.
@hello-kathi damm sorry!!! I thought they were added by richtext input, err this is one of those things that I could do a quick fix on or we go through and properly improve the structure as right now, it's not good.
@phillimorland ok I need a suggestion from you if a quick fix or improvement. I can't estimate how long which solution takes. If the improvement, and yes I think that would be the best option, block you for a longer time then we have to talk about.
@hello-kathi I think to go through and ensure the blocks are correctly structured for accessibility would be maybe 2-3 hours, and then testing and issues. Quick fix i guess is 20 mins plus testing (hopefully no issues as it's a small, contained change)