a4-meinberlin icon indicating copy to clipboard operation
a4-meinberlin copied to clipboard

Don't pass user list to tasks in newsletter

Open ihucos opened this issue 6 years ago • 2 comments

We should not work with lists of ids but with the lazy evaluated querysets. So we need a solution where users are not passed one by one in a list to the tasks, the queryset should be generated inside task or the queryset should be serialized and passed to the task as a queryset.

This issue is a nicer version of https://github.com/liqd/a4-meinberlin/issues/1387

ihucos avatar May 24 '18 14:05 ihucos

@rmader We are still doing that, but were not convinced that we shouldn't. What's your opinion? Should we change it or close the issue? Also, if we change it, that would mean a task for every email? That seems excessive!

fuzzylogic2000 avatar Mar 24 '20 16:03 fuzzylogic2000

The general idea sounds reasonable to me but to quote from #1387:

So this seems not to be really a scaling problem, but something about good practice.

So if this ever becomes a problem we should indeed look into it. Maybe low prio label or simply close :/

rmader avatar Mar 25 '20 09:03 rmader