Separate rockspecs for each backend.
This allows install only needed modules without additional deps.
this is a very clean approach. i am hesitating though since this will releases and versioning more complicate i guess. maybe we can add some tag/release script to this PR?
maybe we can add some tag/release script to this PR?
You mean generate rockspecs? I work on Windows so I think I can use only Lua (not bash) Maybe somewhere there is such a tool.
I found that websocket.tools uses mime module from luasocket.
So I have two options
- Add luasocket in dependencies to websocket.core
- Use some base64 module. And check at load time which one to use (base64, basexx, luasocket).
In this case I suggest add
basexxmodule as dependency because it pure Lua module.
@ntd introduced using luasocket mime here: https://github.com/lipp/lua-websockets/commit/40a02ae4072728e0e4ccd60a0beffacc8b26c6df
lluv changes the premises as every other (minimal) impl always required luasocket.
i'd like to re-add the base64 variant from: https://github.com/lipp/lua-websockets/blob/8c70f5e62e55bdd99dc57ab20f73fdb20cd07c01/src/websocket/tools.lua#L111
so dependencies are not going wild.