URLExtract icon indicating copy to clipboard operation
URLExtract copied to clipboard

Published 20 hours ago • verified publisher icon lipoja

fix-multiple-protocols-in-url

Open amoldavsky opened this issue 2 years ago • 2 comments

Fixes #82

the extraction is incorrect for URLs with multiple protocols:

Link:https://www.google.com
job:https://2.ua/YHfw38

amoldavsky avatar Mar 14 '22 03:03 amoldavsky

Hi @amoldavsky Thank you for your contribution! I appreciate your time spent on it. Could we discuss my point of view for this issue?

I would prefer to not limit schemes to just list defined by us. Maybe we could use the list of schemes from IANA? Since this is nice feature and I think we should include it in the code we might think about a way how to disable it for other users who are relaying on current way of extracting URLs?

lipoja avatar Mar 15 '22 08:03 lipoja

@amoldavsky Hello, may I ask you if you are working on this PR? Or if you are super busy with life as I am :)

lipoja avatar May 17 '22 19:05 lipoja

Thank you for your work! Closing in favor of #146.

lipoja avatar Dec 14 '22 22:12 lipoja