PsIni icon indicating copy to clipboard operation
PsIni copied to clipboard

Abstract away the concept of converting to/from INI format from that of reading/writing an INI file

Open iCodeSometime opened this issue 5 years ago • 5 comments

This library would be much more useful to me if we were to separate the concept of converting to/from ini format from reading/writing files - since really these are separate things.

I propose that we create the functions ConvertTo-Ini and ConvertFrom-Ini, which would match the existing powershell api for JSON, Csv, etc. Out-IniFile and Get-IniContent should then be rewritten to use these new functions.

Pros:

  • More flexible
  • More consistent with similar existing PS functionality

Cons:

  • ???

I need this ability for my project and am working on this. I'm happy to consider any feedback and send a PR if you agree this would be useful

iCodeSometime avatar Apr 29 '19 17:04 iCodeSometime

Fair point. I will make a new major release renaming to Import- and Export- adding ConvertTo- and ConvertFrom-

lipkau avatar Apr 30 '19 16:04 lipkau

Thanks @lipkau!

I take that to mean you're uninterested in a PR for this?

iCodeSometime avatar May 01 '19 18:05 iCodeSometime

Well... I do want to change quite a bit in the tests and CI pipeline. I can push my current status to a branch, and if you are interested in help, it will be very welcome

lipkau avatar May 02 '19 11:05 lipkau

https://github.com/lipkau/PsIni/tree/release/4.0

lipkau avatar May 02 '19 22:05 lipkau

Yeah, I'll take a look and see what I can do.

I really appreciate your enthusiasm about this proposal, it'll significantly increase the usefulness of this project for me.

iCodeSometime avatar May 03 '19 18:05 iCodeSometime