coriolis icon indicating copy to clipboard operation
coriolis copied to clipboard

Changes in coriolis that require changes in alliance-test-suite are difficult

Open robtaylor opened this issue 2 years ago • 1 comments

At the moment, if one needs to change alliance-check-toolkit for a change in coriolis, there's not a good sequence to do it in - you'll either have the new PR failing regression check, or main failing.

Any thoughts welcome!

robtaylor avatar Sep 02 '23 10:09 robtaylor

I grappled with the same issue. It would be nice to be able to run old commits with newer versions of alliance-check-toolkit as well. My solution would be to add a "ref" to the checkout of alliance-check-toolkit in .github/workflows/regressions.yml. This way we point a specific commit or tag that should work.

- uses: actions/checkout@v3
       with:
         repository: lip6/alliance-check-toolkit
         path:       coriolis-2.x/src/alliance-check-toolkit
         ref:        67b799e7b208

Coloquinte avatar Oct 18 '23 11:10 Coloquinte