fast-elasticsearch-vector-scoring icon indicating copy to clipboard operation
fast-elasticsearch-vector-scoring copied to clipboard

Published 20 hours ago • verified publisher icon lior-k

Changed script to work with Elastic 6.0.0.

Open Zakkery opened this issue 5 years ago • 4 comments

Hi,

This should be working on Elastic 6.0.0. They really simplified design of scoring scripts so it is now only one file, pretty much. Inline scripts are now depreciated so using 'source' field instead. I had to also alter test files since Elastic 6.0.0 uses Netty4Plugin now and some settings are now disabled. I tested it on real data and it seems to work, but let me know if you have any concern.

Best, Zakkery

Zakkery avatar Jan 30 '19 22:01 Zakkery

Hi Zakkery. Thanks for the PR. I'll add my comments in-line But 1 in general - several files instead of 1 helps me keep the clutter of Plugin boiler plate away & focus only on the 2 important methods: run & compile. I would really appreciate it If you can move the clutter to separate files & keep indentation to a minimum

lior-k avatar Feb 02 '19 19:02 lior-k

I broke it back into multiple files, like you suggested and fixed code according to your comments.

Zakkery avatar Apr 04 '19 14:04 Zakkery

Hi Zakkery. note that master was changed to use float vectors instead of doubles. please review your changes against master. thanks

lior-k avatar Apr 23 '19 18:04 lior-k

Hi Zakkery. note that master was changed to use float vectors instead of doubles. please review your changes against master. thanks

I just did a rebase, I guess I forgot to do it, now should be all floats and merged properly.

Zakkery avatar Apr 23 '19 19:04 Zakkery