codegrip icon indicating copy to clipboard operation
codegrip copied to clipboard

Adhere to tidyverse style guide

Open krlmlr opened this issue 1 year ago • 3 comments

See https://github.com/tidyverse/style/issues/173#issuecomment-904073980 and https://github.com/tidyverse/style/pull/174 for context.

CC @lionel-.

krlmlr avatar Aug 14 '23 16:08 krlmlr

After having written some Typescript and Rust code, I think balanced delimiters are probably more conventional overall?

lionel- avatar Sep 28 '23 07:09 lionel-

I no longer have a strong preference, I have settled for whatever the tidyverse style guide suggests. Are you willing to reopen that discussion upstream? It looks like an uphill battle to me.

Should we offer both options here, i.e., cycle through the tidyverse and the TS/Rust way?

krlmlr avatar Sep 29 '23 11:09 krlmlr

As a Rust programmer and an R programmer, I quite appreciate that codegrip formats function arguments to have the closing paren and leading { on their own line. The unbalanced closing of the tidyverse style guide feels....unbalanced. It would be great to have the default be balance and opt-in to the tidyverse style guide.

JosiahParry avatar Mar 27 '24 13:03 JosiahParry