github-wiki-search icon indicating copy to clipboard operation
github-wiki-search copied to clipboard

after search, matched term in anchor's href URL messes up link

Open blairconrad opened this issue 10 years ago • 0 comments

That's what it seems to me. I've not analyzed the code yet, but you can reproduce by searching for "strict" in the FakeItEasy wiki, then choosing the "Creating Fakes" page from the results. Or just click on this URL that's generated by the extension:

https://github.com/FakeItEasy/FakeItEasy/wiki/Creating-Fakes#search_word=strict

Witness the result:

image

Compared to the original page at https://github.com/FakeItEasy/FakeItEasy/wiki/Creating-Fakes (or replicate with the longer URL and the extension disabled):

image

The problem does not seem to occur when the target word is part of the link text, as can be shown by reaching the same page when searching for "mocking" (or just hit https://github.com/FakeItEasy/FakeItEasy/wiki/Creating-Fakes#search_word=mocking):

image

Aside from that, I'm really enjoying the extension, and if you're interested in farming out the work on this issue, I'm available to contribute.

blairconrad avatar Aug 13 '14 01:08 blairconrad