Lin Yihai

Results 25 comments of Lin Yihai

In the commit I add a `public` field when publish a crate, but this is only for test. We should also support upload the `public` field when publish crates to...

> In the commit I add a `public` field when publish a crate, but this is only for test. > > We should also support upload the `public` field when...

> Sorry, had overlooked that message. Yes, we need to add publish support. Looking at bindeps and artifacts, it looks like we do that for unstable features today. > >...

> One fix I can think of is comparing if the value of --precise is a hex string of 40/64 characters [here](https://github.com/rust-lang/cargo/blob/363a2d11320faf531f6aacd1ea067c6bc08343b9/src/cargo/ops/cargo_generate_lockfile.rs#L112), and give a nice error if not. I...

> > One fix I can think of is comparing if the value of --precise is a hex string of 40/64 characters [here](https://github.com/rust-lang/cargo/blob/363a2d11320faf531f6aacd1ea067c6bc08343b9/src/cargo/ops/cargo_generate_lockfile.rs#L112), and give a nice error if not....

> Oops. I didn't realize this is claimed. Sorry for that, @linyihai 😔 > > Actually I was trying to provide guidance but ended up writing a fix The content...

@rustbot claim I'm going to try, and if I haven't moved for a long time, feel free to pick it up and continue.

Each option for a build configuration has pros and cons, depending on the needs of the developer. But I do need some predefined templates or configurations to make the build...

> Pls look into fixing this in a more general way Hope my latest submit general enough, I haven't see other code modules, such as the hir: : CoroutineKind: :...