docker-fail2ban icon indicating copy to clipboard operation
docker-fail2ban copied to clipboard

Added iptables-legacy to installed packages

Open dustinwilson opened this issue 1 year ago • 4 comments

linuxserver.io


  • [x ] I have read the contributing guideline and understand that I have made the correct modifications

Description:

The recent rebase to Alpine 3.19 broke the functionality on hosts which use iptables such as Unraid. This PR also installs the Alpine package iptables-legacy so that users on these systems may still use the container. This PR fixes #25.

Benefits of this PR and context:

The container is unusable on hosts which only have iptables. With this PR it will remain usable.

How Has This Been Tested?

Installed a container on two computers, one which is an Unraid system and another an Arch linux system. The Unraid one uses iptables while the Arch one uses nftables. I configured fail2ban to monitor ssh on each, and an entry was added to the tables for ssh as expected. After multiple test unsuccessful attempts it blocked me afterwards. @danielaranki performed a similar test last week and showed his findings in #25.

The user will need to specify in their jail.local file which backend to use (also pointed out by @danielaranki in #25):

banaction = iptables-multiport[iptables=iptables-legacy]

dustinwilson avatar May 24 '24 05:05 dustinwilson

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-a4dab79a-dev-7c79365b68862a9114204d7fbd1ec6824b26579b-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-a4dab79a-dev-7c79365b68862a9114204d7fbd1ec6824b26579b-pr-26/shellcheck-result.xml

Tag Passed
amd64-1.0.2-r3-pkg-a4dab79a-dev-7c79365b68862a9114204d7fbd1ec6824b26579b-pr-26
arm64v8-1.0.2-r3-pkg-a4dab79a-dev-7c79365b68862a9114204d7fbd1ec6824b26579b-pr-26

LinuxServer-CI avatar Jun 18 '24 15:06 LinuxServer-CI

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-70d76770-dev-330801d4feee2895657c0ca41c44af8d194f8495-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-70d76770-dev-330801d4feee2895657c0ca41c44af8d194f8495-pr-26/shellcheck-result.xml

Tag Passed
amd64-1.0.2-r3-pkg-70d76770-dev-330801d4feee2895657c0ca41c44af8d194f8495-pr-26
arm64v8-1.0.2-r3-pkg-70d76770-dev-330801d4feee2895657c0ca41c44af8d194f8495-pr-26

LinuxServer-CI avatar Jul 15 '24 15:07 LinuxServer-CI

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-07be558e-dev-f090218fe0452ffe14603afba9cff51dbc2dc906-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-07be558e-dev-f090218fe0452ffe14603afba9cff51dbc2dc906-pr-26/shellcheck-result.xml

Tag Passed
amd64-1.0.2-r3-pkg-07be558e-dev-f090218fe0452ffe14603afba9cff51dbc2dc906-pr-26
arm64v8-1.0.2-r3-pkg-07be558e-dev-f090218fe0452ffe14603afba9cff51dbc2dc906-pr-26

LinuxServer-CI avatar Aug 11 '24 15:08 LinuxServer-CI

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-baee7599-dev-d6bc2ba25e43e2c8c28a9ed7f1069d3c80cfc61a-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-baee7599-dev-d6bc2ba25e43e2c8c28a9ed7f1069d3c80cfc61a-pr-26/shellcheck-result.xml

Tag Passed
amd64-1.0.2-r3-pkg-baee7599-dev-d6bc2ba25e43e2c8c28a9ed7f1069d3c80cfc61a-pr-26
arm64v8-1.0.2-r3-pkg-baee7599-dev-d6bc2ba25e43e2c8c28a9ed7f1069d3c80cfc61a-pr-26

LinuxServer-CI avatar Sep 07 '24 15:09 LinuxServer-CI

I am a bot, here are the test results for this PR: https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-56777ab5-dev-d40135ac81953cddac83d8019f7c2e38929257ba-pr-26/index.html https://ci-tests.linuxserver.io/lspipepr/fail2ban/1.0.2-r3-pkg-56777ab5-dev-d40135ac81953cddac83d8019f7c2e38929257ba-pr-26/shellcheck-result.xml

Tag Passed
amd64-1.0.2-r3-pkg-56777ab5-dev-d40135ac81953cddac83d8019f7c2e38929257ba-pr-26
arm64v8-1.0.2-r3-pkg-56777ab5-dev-d40135ac81953cddac83d8019f7c2e38929257ba-pr-26

LinuxServer-CI avatar Oct 04 '24 15:10 LinuxServer-CI

I see no reason to not add this in, we do this in swag for fail2ban also. once #29 is merged, this will need to be updated against that. Apologies for the delays on this, it slipped our notice, but at least you get some hacktoberfest credit for it now :)

drizuid avatar Oct 12 '24 13:10 drizuid