docker-baseimage-kasmvnc icon indicating copy to clipboard operation
docker-baseimage-kasmvnc copied to clipboard

[FEAT] s6 readiness checking

Open Joker9944 opened this issue 1 year ago • 2 comments

Is this a new feature request?

  • [X] I have searched the existing issues

Wanted change

Currently all s6 services report only up or down but not if they are ready or not. It would be nice to know if the services are ready to receive traffic.

Here is the documentation I found regarding readiness checking: https://skarnet.org/software/s6/notifywhenup.html

Reason for change

I'm writing a Kubernetes workload with an image based on this base image the service up status is great for startup and liveness probes but insufficient for readiness checks. Currently I'm checking like this /usr/bin/s6-svstat -o up /run/service/svc-kclient | grep --quiet true.

Proposed code change

I do know very little about kasm and s6 but am happy to volunteer my time. So I wanted to check first with the maintainers of this repo if a feature like this is feasible or even desirable.

Joker9944 avatar Aug 27 '24 10:08 Joker9944

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

github-actions[bot] avatar Aug 27 '24 10:08 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI avatar Sep 26 '24 17:09 LinuxServer-CI

This issue is locked due to inactivity

LinuxServer-CI avatar Dec 26 '24 17:12 LinuxServer-CI