docker-baseimage-kasmvnc icon indicating copy to clipboard operation
docker-baseimage-kasmvnc copied to clipboard

[FEAT] File drag and drop support

Open Pastitas opened this issue 1 year ago • 7 comments

Is this a new feature request?

  • [X] I have searched the existing issues

Wanted change

Add an togglable option to make the app upload automatically any files that are dragged and dropped there in the main page (maybe using some default upload folder setting) .

If this could somehow be integrated with the vnc host to drag the same file to the used application inside would be amazing but that seems way more complex, maybe that could be a future improvement

Reason for change

Right now there's no action associated with dragging and dropping files on kasmvnc webpage, instead the default action by the browser is done. Also in the settings menu there's an option for file upload that, when that specific window is open, allows for file uploads via drag and drop.

This makes sense for applications in which you'd normally want to drag and drop a file into, like https://github.com/linuxserver/docker-orcaslicer

Proposed code change

No response

Pastitas avatar May 28 '24 09:05 Pastitas

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

github-actions[bot] avatar May 28 '24 09:05 github-actions[bot]

You would need to send this feature request to Kasm.

j0nnymoe avatar May 28 '24 09:05 j0nnymoe

Opened an issue and was told that the kasmvnc is not the component that does this, so I assumed it was on your side https://github.com/kasmtech/KasmVNC/issues/250 Where can I open this then if its not there nor here? It's unclear to me where the feature I'm currently using for uploads comes from

Pastitas avatar May 28 '24 09:05 Pastitas

Our baseimage consumes this repo: https://github.com/kasmtech/noVNC/ .

I'll tag in @thelamer as he'll have more knowledge on all this. Side note to what you're wanting to do, I would suggest mounting an additional volume which you keep your 3d print files in. Personally I have /models mounted which is shared with a few other things.

j0nnymoe avatar May 28 '24 10:05 j0nnymoe

Thanks, I've created an issue there and closed the other one, this might be closed then aswell when they confirm it's their feature https://github.com/kasmtech/noVNC/issues/109

Pastitas avatar May 28 '24 10:05 Pastitas

The KasmVNC protocol does not have any file functionality that is something we bolt on with Kclient. Draggable overlay divs generally can block other specific interaction with the page depending on the browser (keyboard or mouse input) which is why it is scoped to the file browser modal.

thelamer avatar May 28 '24 11:05 thelamer

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

LinuxServer-CI avatar Jun 27 '24 17:06 LinuxServer-CI

This issue is locked due to inactivity

github-actions[bot] avatar Sep 26 '24 18:09 github-actions[bot]