Heimdall icon indicating copy to clipboard operation
Heimdall copied to clipboard

Add an option to use Trianglify for the background

Open ullbergm opened this issue 6 years ago • 9 comments

This will give you the option to use Trianglify instead of a background picture for some random background art.

ullbergm avatar Jun 04 '18 23:06 ullbergm

There are a lot of file changes here, but it looks like an interesting addition. Do you have a screenshot of what it looks like?

KodeStar avatar Jun 05 '18 11:06 KodeStar

The color and pattern changes each refresh.

If you want to try it out you can pull ullbergm/heimdall

trianglify

ullbergm avatar Jun 05 '18 11:06 ullbergm

Stick a check on app.blade.php as to whether trianglify is actually being used before loading the trianglify scripts and I'll approve this. Thanks for the contribution and sorry it's taken so long.

KodeStar avatar Jun 10 '18 07:06 KodeStar

Good point, didn't think about that.

ullbergm avatar Jun 10 '18 11:06 ullbergm

would love to see this in heimdall 👍

kimpenhaus avatar Aug 03 '19 11:08 kimpenhaus

How do you enable it ? I've got 2.2.2 from docker

lennvilardi avatar Apr 30 '20 15:04 lennvilardi

Can this be merged @KodeStar ?

Macleykun avatar Mar 27 '22 19:03 Macleykun

If the conflicts in the files are resolved... probably.

KodeStar avatar Apr 06 '22 09:04 KodeStar

This looks amazing - would be great to see this added if possible!

EDIflyer avatar Jul 16 '22 17:07 EDIflyer

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Apr 09 '23 15:04 github-actions[bot]

bump to stop this going stale - would still be a nice addition

EDIflyer avatar Apr 09 '23 16:04 EDIflyer

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 11 '23 15:05 github-actions[bot]

bump to avoid being marked as stale

EDIflyer avatar May 11 '23 17:05 EDIflyer

@EDIflyer it's likely this isn't going to get added as the OP hasn't replied in 4+ years. It's already been said that the conflicts need to be resolved first (plus it problems needed to be rebased aswell.)

j0nnymoe avatar May 11 '23 17:05 j0nnymoe

fair point, although @ullbergm looks to still be active on Github so hoping they might be up for a quick rebase/problem fix as it looks great in the screenshot :)

EDIflyer avatar May 11 '23 17:05 EDIflyer

Been a while since I looked at this.. which branch should the PR be against? This old one is against 'master' but it looks like '2.x' is the default.

ullbergm avatar May 11 '23 19:05 ullbergm

Created a new PR #1158 for the 2.x branch instead of master.

Also added an option to specify the random seed so that the background doesn't change between each transition to another page. If the seed is an empty string you will get a new random background each time.

ullbergm avatar May 12 '23 23:05 ullbergm

Closing in favor of #1158

ullbergm avatar May 18 '23 11:05 ullbergm