chkservice icon indicating copy to clipboard operation
chkservice copied to clipboard

Published 20 hours ago • verified publisher icon linuxenko

Fix bug caused by temporary pointer of c_str() in auto id (reissue of #22 with english commit)

Open JJRcop opened this issue 3 years ago • 3 comments

This is identical to #22 except for the commit title was changed to English. Based on the title of #22.

I confirmed with google translate that the original Chinese commit title was semantically equivalent to the title of #22

Screenshot_20210817_183234

Closes #22 Fixes #12

JJRcop avatar Aug 17 '21 15:08 JJRcop

probably should have commented here instead, but see https://github.com/linuxenko/chkservice/pull/22#discussion_r715997107

adamdicarlo avatar Sep 25 '21 06:09 adamdicarlo

My experience with C++ is not enough for me to know whether that is correct or not... I just knew that the old PR was put on hold because of a trivial issue (git commit name) I knew how to fix, so I fixed it and made a new PR.

@adamdicarlo If you think that's right, fork my branch and make a new PR! I just can't get behind this suggested change because of my inexperience.

JJRcop avatar Oct 22 '21 17:10 JJRcop

@linuxenko can you look at this? chkservice did not make it into Debian 11 because of #12. #22 fixes #12 but you wanted an English commit title, and this PR does that.

JJRcop avatar Aug 12 '22 17:08 JJRcop