chkservice
chkservice copied to clipboard
linuxenko
Added search feature
Deisgn decision:
- Instead of maintaining a separate "search results" units list, the main units list becomes the "search results" one. This means that to go back to the "full" list, user has to press 'r'.
This design is debatable. A separate "search results" list can be added and maintained, but it means significant changes of the current chkservice implementation.
Signed-off-by: Gilles Talis [email protected]
It is a quite interesting feature that has lots of implemetations. The most convinient, as I think, implemented in wide range of GNU programs, such as info , man .. .. Despite GNU book of standards says nothing about design and UI, it says exactly one thing - do not confuse the user :)
I've built this PR and it was very simple, I didn't refer to the source code, I just press /, as usual, and search dialog appears, it is nice.
What do I think in general about the feature. I was thinking about it as an readline integration (by the way, I always forget to implement emacs keys). But there was something that stopped me, I need to dive into it to find out what was the problem.
Thanks for the review / comment. I am not a readline expert, but I would love to hear about what you have in mind and possibly help with the implementation if you need my assistance.
I'm sure we can use this filters to filter units by their type such as sockets, services .. Let me know if you have any ideas about it, it would be nice to release 0.4 with filters (currently the only 0.1 released because I'm not sure if those new features are stable enough)