linuxdeploy-plugin-qt icon indicating copy to clipboard operation
linuxdeploy-plugin-qt copied to clipboard

Fix linuxdeploy log directory rename

Open dantti opened this issue 1 year ago • 3 comments

Since I needed linuxdeploy-plugin-qt that had the --exclude-libraries working I make the github workflows run on my fork and and have this issue when using a newer (+my patch) linuxdeploy submodule.

dantti avatar Jun 18 '24 21:06 dantti

For context, this adjustment is necessary in response to https://github.com/linuxdeploy/linuxdeploy/commit/2b73a2173f8acfc0269e681bdb28ebf65b0b4b48.

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

bjorn avatar Jun 19 '24 09:06 bjorn

It's a bit unfortunate the move happened as part of "Improve logging of failed subprocesses", since it makes it very hard to see what the actual improvement was (I couldn't spot it).

You're absolutely right about this. This was rushed a bit. It shouldn't be a big deal to use a tool like Meld and diff the old and new code, though.

At any rate, @dantti please rebase this branch, then we can merge it.

TheAssassin avatar Aug 03 '24 00:08 TheAssassin

@TheAssassin this is ready to be merged, CI is broken due other stuff (which a few are addressed in another PR)

dantti avatar Oct 17 '24 13:10 dantti

@TheAssassin ping

dantti avatar Jul 17 '25 13:07 dantti

rebased again

dantti avatar Aug 14 '25 20:08 dantti

Sorry for the delay, have not had any time to review this before.

TheAssassin avatar Aug 18 '25 18:08 TheAssassin

Thanks a lot!

TheAssassin avatar Aug 18 '25 18:08 TheAssassin