linuxdeploy-plugin-conda icon indicating copy to clipboard operation
linuxdeploy-plugin-conda copied to clipboard

Make install part skippable

Open knarfS opened this issue 4 years ago • 1 comments

In some scenarios the conda plugin has to be installed before the linuxdeploy process (not as a linuxdeploy plugin), e.g. when a Python environment is needed to build the application. In this case, a cleanup must not be performed before the actual linuxdeploy process, but after it. Therefore it must be possible to skip the install part.

knarfS avatar Jun 25 '21 14:06 knarfS

I see your point. But I think your approach is wrong here. I'd rather introduce a CONDA_CLEANUP_ONLY, which carries your intention a lot better. I guess the name is inspired by CONDA_SKIP_CLEANUP. However, I don't think this tool has two stages "install" and "cleanup" (I think more fine grainedly), or that it will be like that forever. CONDA_CLEANUP_ONLY is exactly the opposite of CONDA_SKIP_CLEANUP.

Have you seen https://github.com/linuxdeploy/linuxdeploy/issues/68? Would introducing such stages fix the issue for you, or do you really need/want to manually set up a conda dir, then run your own script stuff, and then move on to cleaning up? I think with stages and a custom linuxdeploy plugin, you could likely achieve what you want to, too, but this is just a guess. I'd like to hear more about your use case. Perhaps you can share a script?

TheAssassin avatar Jun 27 '21 02:06 TheAssassin