dtkwidget
dtkwidget copied to clipboard
fix: DLineEdit增加Alert文本对齐接口
DLineEdit的Alert文本默认是居中对齐,针对多行文本的情况需要控制其对齐方向; 原接口setMessageAlignment是修改Alert弹框的对齐方式,接口名称容易误解成修改文本,将其实现修改成文本对齐方式; 新接口setAlertAlignment,用于修改Alert弹框的对齐方式;
Log: Influence: DLineEdit的Alert效果 Change-Id: I251400365fc6fdc29ee1cb1f11efdc81eaf2d939
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: shao-jun
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
deepin pr auto review
关键摘要:
DAlertControl类中的setMessageAlignment和messageAlignment方法被重命名为setAlertAlignment和alertAlignment,但注释中仍然提到setMessageAlignment,这可能会导致混淆。DLineEdit类中新增的setAlertAlignment和alertAlignment方法应该与DAlertControl类中的方法保持一致,以避免混淆。DAlertControl类中的showAlertMessage方法中新增了对d->messageAlignment的设置,但未在注释中说明这一变化。DAlertControlPrivate类中新增了messageAlignment成员变量,但未在注释中说明其用途。
是否建议立即修改: 是
- 应该立即更新注释,确保它们与实际的方法名称和功能一致。
- 应该检查
DLineEdit类中的新增方法是否与DAlertControl类中的方法保持一致,并在必要时进行相应的调整。 - 应该在
DAlertControlPrivate类中添加适当的注释,说明messageAlignment成员变量的用途。
TAG Bot
New tag: 5.7.14 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #655
TAG Bot
New tag: 5.7.15 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #661
TAG Bot
New tag: 5.7.16 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #662
TAG Bot
New tag: 5.7.17 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #666
TAG Bot
New tag: 5.7.18 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #668
TAG Bot
New tag: 5.7.19 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #670