deepin-movie-reborn icon indicating copy to clipboard operation
deepin-movie-reborn copied to clipboard

fix(libdmr): strip LoongArch out of Platform::Mips

Open MingcongBai opened this issue 1 year ago • 8 comments

LoongArch is not MIPS-based Loongson and exhibits significantly different performance characteristics (try ~50 - 100% faster with current hardware versus 3A4000).

There is no need to strip out functionalities in order to obtain acceptable performance. The current 3A6000 processors can easily keep up with 10th Gen Intel i3 processors.

MingcongBai avatar Aug 02 '24 06:08 MingcongBai

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions[bot] avatar Aug 02 '24 06:08 github-actions[bot]

Re-submitted with company e-mail.

MingcongBai avatar Aug 02 '24 06:08 MingcongBai

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MingcongBai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Aug 02 '24 06:08 deepin-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MingcongBai

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Aug 02 '24 06:08 deepin-ci-robot

deepin pr auto review

关键摘要:

  • compositing_manager.cpp文件中,注释应该准确反映代码的功能,而不是包含拼写错误。建议将注释修改为"match shenwei",以避免混淆。
  • compositing_manager.h文件中,注释应该保持简洁明了,避免使用复杂的句子和过多的细节。当前的注释"MIPS-based Loongson"已经足够清晰地表达了平台的意图。

是否建议立即修改:

  • 是,注释应该准确反映代码的功能和意图,以便于理解和维护代码。

deepin-ci-robot avatar Aug 02 '24 06:08 deepin-ci-robot

TAG Bot

New tag: 6.0.11 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #524

deepin-bot[bot] avatar Sep 30 '24 02:09 deepin-bot[bot]

TAG Bot

New tag: 6.0.12 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #567

deepin-bot[bot] avatar Feb 05 '25 08:02 deepin-bot[bot]

TAG Bot

New tag: 6.0.13 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #573

deepin-bot[bot] avatar Feb 11 '25 05:02 deepin-bot[bot]