deepin-movie-reborn icon indicating copy to clipboard operation
deepin-movie-reborn copied to clipboard

fix: don't override system CMAKE_EXE_LINKER_FLAGS and don't set -fPIE…

Open felixonmars opened this issue 2 years ago • 17 comments

… for shared libraries

  • Append to CMAKE_EXE_LINKER_FLAGS instead of overriding it.
  • -fPIE is invalid for shared libraries. Removing it here fixes building for Arch. Please use --enable-default-pie for gcc instead of inserting PIE flags to every package.

felixonmars avatar Sep 20 '23 12:09 felixonmars

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felixonmars

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Sep 20 '23 12:09 deepin-ci-robot

TAG Bot

New tag: 5.10.39 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #398

deepin-bot[bot] avatar Dec 22 '23 03:12 deepin-bot[bot]

TAG Bot

New tag: 5.10.40 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #407

deepin-bot[bot] avatar Jan 05 '24 02:01 deepin-bot[bot]

TAG Bot

New tag: 5.10.41 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #411

deepin-bot[bot] avatar Jan 10 '24 06:01 deepin-bot[bot]

TAG Bot

New tag: 6.0.6 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #412

deepin-bot[bot] avatar Jan 16 '24 05:01 deepin-bot[bot]

TAG Bot

New tag: 5.10.42 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #415

deepin-bot[bot] avatar Jan 19 '24 03:01 deepin-bot[bot]

TAG Bot

New tag: 5.10.43 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #419

deepin-bot[bot] avatar Feb 01 '24 06:02 deepin-bot[bot]

TAG Bot

New tag: 5.10.44 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #420

deepin-bot[bot] avatar Feb 05 '24 06:02 deepin-bot[bot]

TAG Bot

New tag: 5.10.45 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #425

deepin-bot[bot] avatar Mar 01 '24 06:03 deepin-bot[bot]

TAG Bot

New tag: 5.10.46 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #429

deepin-bot[bot] avatar Mar 13 '24 07:03 deepin-bot[bot]

TAG Bot

New tag: 6.0.7 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #444

deepin-bot[bot] avatar Apr 12 '24 09:04 deepin-bot[bot]

TAG Bot

New tag: 6.0.8 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #465

deepin-bot[bot] avatar May 28 '24 07:05 deepin-bot[bot]

TAG Bot

New tag: 6.0.9 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #480

deepin-bot[bot] avatar Jun 26 '24 08:06 deepin-bot[bot]

TAG Bot

New tag: 6.0.10 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #492

deepin-bot[bot] avatar Jul 10 '24 02:07 deepin-bot[bot]

TAG Bot

New tag: 6.0.11 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #524

deepin-bot[bot] avatar Sep 30 '24 02:09 deepin-bot[bot]