deepin-anything icon indicating copy to clipboard operation
deepin-anything copied to clipboard

Mutilple fixed

Open hillwoodroc opened this issue 5 months ago • 4 comments
trafficstars

  • Add mount pkg-config flags to library Makefile
  • Update dependencies in deepin-anything-server-lib.pc.in

Summary by Sourcery

Add mount dependency to the library build and update the package config template to reflect the new dependency

Enhancements:

  • Introduce pkg-config cflags and libs for mount in the library Makefile
  • Include mount flags in the compilation and linking steps
  • Update dependencies in deepin-anything-server-lib.pc.in

hillwoodroc avatar Jun 06 '25 08:06 hillwoodroc

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hillwoodroc

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Jun 06 '25 08:06 deepin-ci-robot

Hi @hillwoodroc. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deepin-ci-robot avatar Jun 06 '25 08:06 deepin-ci-robot

Reviewer's Guide

This PR integrates mount library support into the build system by extending pkg-config flags in the library Makefile and updating the pkg-config metadata in the .pc.in template.

File-Level Changes

Change Details Files
Introduce mount pkg-config flags into the library build
  • Define MOUNT_INCL and MOUNT_LIB via pkg-config
  • Inject ${MOUNT_INCL} into INCLUDE_DIR
  • Append ${MOUNT_LIB} to LDFLAGS
src/library/Makefile
Update pkg-config dependencies in the .pc.in template
  • Add mount to the Requires list
src/server/backend/deepin-anything-server-lib.pc.in

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar Jun 06 '25 08:06 sourcery-ai[bot]

TAG Bot

New tag: 6.2.10 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #179

deepin-bot[bot] avatar Jun 19 '25 12:06 deepin-bot[bot]