dde-daemon icon indicating copy to clipboard operation
dde-daemon copied to clipboard

Published 20 hours ago • verified publisher icon linuxdeepin

fix: connect to pulseaudio timeout

Open zsien opened this issue 1 year ago • 5 comments

Waiting for the services to active

Bug: https://pms.uniontech.com/bug-view-275185.html

zsien avatar Sep 24 '24 12:09 zsien

TAG Bot

TAG: 6.0.46 EXISTED: no DISTRIBUTION: unstable

github-actions[bot] avatar Sep 25 '24 05:09 github-actions[bot]

deepin pr auto review

关键摘要:

  • 在startAudioServer函数中，wg.Add(1)和wg.Done()的使用可能会导致竞态条件，因为wg.Done()在if value == "active" && !actived条件成立时被调用，而wg.Add(1)在if state != "active"条件不成立时被调用。这可能会导致wg.Wait()在state变为"active"时立即返回，而没有等待wg.Done()完成。
  • serverSystemdUnit.InitSignalExt(sigLoop, true)的调用可能不会按预期工作，因为serverSystemdUnit.Unit().ActiveState().ConnectChanged的连接应该已经通过serverSystemdUnit.InitSignalExt初始化。
  • logger.Warning("failed to get audio server active state", err)可能会导致日志输出错误，因为err可能不是预期的错误类型。
  • wg.Wait()在循环中调用可能会导致程序在等待事件完成时无限期地阻塞。

是否建议立即修改: 是

deepin-ci-robot avatar Sep 25 '24 05:09 deepin-ci-robot

/integrate

zsien avatar Sep 25 '24 05:09 zsien

AutoIntegrationPr Bot auto integrate with pr url: https://github.com/deepin-community/Repository-Integration/pull/2037 PrNumber: 2037 PrBranch: auto-integration-11026869308

github-actions[bot] avatar Sep 25 '24 05:09 github-actions[bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Oct 11 '24 02:10 deepin-ci-robot