dde-daemon icon indicating copy to clipboard operation
dde-daemon copied to clipboard

fix: archlinux build error

Open hudeng-go opened this issue 1 year ago • 10 comments
trafficstars

高版本ddcutil需要单独添加ddcutil_types.h才能保证cgo能正常构建

log:

hudeng-go avatar Apr 19 '24 07:04 hudeng-go

需要https://github.com/deepin-community/ddcutil/pull/1 先集成。

hudeng-go avatar Apr 19 '24 08:04 hudeng-go

/hold

hudeng-go avatar Apr 19 '24 08:04 hudeng-go

/cc @wineee

hudeng-go avatar Apr 19 '24 08:04 hudeng-go

/cc @zsien

hudeng-go avatar Apr 19 '24 08:04 hudeng-go

等下, deepin 构建挂了

upd: 可能要等集成

wineee avatar Apr 19 '24 08:04 wineee

TAG Bot

New tag: 6.0.38 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #626

deepin-bot[bot] avatar Apr 23 '24 08:04 deepin-bot[bot]

TAG Bot

New tag: 6.0.39 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #628

deepin-bot[bot] avatar Apr 30 '24 00:04 deepin-bot[bot]

这个 pr 可以合吗?

wineee avatar May 14 '24 05:05 wineee

/hold

hudeng-go avatar May 30 '24 09:05 hudeng-go

TAG Bot

New tag: 6.0.40 DISTRIBUTION: unstable Suggest: synchronizing this PR through rebase #632

deepin-bot[bot] avatar Jun 05 '24 01:06 deepin-bot[bot]

deepin pr auto review

关键摘要:

  • newDDCCI函数中,C.ddca_init2函数调用缺少了C.DDCA_INIT_OPTIONS_CLIENT_OPENED_SYSLOG选项,可能会影响初始化行为。
  • C.CString函数的使用应该确保字符串在C中是安全的,避免内存泄露。
  • filepath.Join函数的使用应该检查content变量是否为空,以避免潜在的空指针异常。
  • 错误消息的更改应该反映实际的错误原因,而不是仅仅替换字符串。

是否建议立即修改: 是

deepin-ci-robot avatar Jun 05 '24 09:06 deepin-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hudeng-go, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Jun 19 '24 02:06 deepin-ci-robot