dde-control-center icon indicating copy to clipboard operation
dde-control-center copied to clipboard

chore: compatible to new dock

Open FeiWang1119 opened this issue 1 year ago • 3 comments

pass the paths of icons instead of the pixmap of icons

Log:

FeiWang1119 avatar Jul 05 '24 03:07 FeiWang1119

截图_选择区域_20240705143814 截图_选择区域_20240705143649

FeiWang1119 avatar Jul 05 '24 06:07 FeiWang1119

/topic shell-tray-loader

FeiWang1119 avatar Jul 08 '24 05:07 FeiWang1119

Add topic: shell-tray-loader successed.

deepin-ci-robot avatar Jul 08 '24 05:07 deepin-ci-robot

TAG Bot

TAG: 6.0.58 EXISTED: no DISTRIBUTION: unstable

github-actions[bot] avatar Jul 09 '24 03:07 github-actions[bot]

/help

kegechen avatar Jul 09 '24 09:07 kegechen

@kegechen:

deepin pr commands help details.

常用命令:

  • /integrate 集成单个包
  • /topic $name 添加pr到topic
  • /integr-topic $name 集成topic,只需要在任意一个pr中输入一次即可,topic有更新在重新刷一次
  • /merge 没有开机器人自动合并的用这个合并代码
  • /retest 重试出错的ci任务,/test all 执行所有ci任务,/test $name执行指定的ci任务
  • /check obs linuxdeepin组织下专属命令,应对该组织下obs ci任务未成功执行的情况,执行后仍然有问题可以有节奏的关闭-->打开pr一下,还是有问题可以急call管理员

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deepin-ci-robot avatar Jul 09 '24 09:07 deepin-ci-robot

/approved

kegechen avatar Jul 09 '24 09:07 kegechen

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: FeiWang1119, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Jul 10 '24 00:07 deepin-ci-robot

deepin pr auto review

关键摘要:

  • DockModuleObject类的updateIcons私有槽函数中,存在对m_pluginModel的直接访问,违反了封装原则。
  • getIcon函数的实现已经更改,但未提供新的参数dccIcon的定义和说明,可能会导致使用上的混淆。
  • eventFilter函数的实现未提供足够的上下文信息,例如watched对象和event对象的数据类型和来源,这可能会影响代码的可维护性。
  • updateIcons函数中使用了dynamic_cast,但没有检查转换是否成功,可能会导致运行时错误。

是否建议立即修改: 是

deepin-ci-robot avatar Jul 15 '24 03:07 deepin-ci-robot

/integr-topic shell-tray-loader

FeiWang1119 avatar Jul 15 '24 03:07 FeiWang1119

Integrated with pr https://github.com/deepin-community/Repository-Integration/pull/1727

deepin-ci-robot avatar Jul 15 '24 03:07 deepin-ci-robot