dde-api icon indicating copy to clipboard operation
dde-api copied to clipboard

fix: no logout sound

Open zsien opened this issue 1 year ago • 11 comments

Issues: linuxdeepin/developer-center#9370

zsien avatar Jun 20 '24 08:06 zsien

deepin pr auto review

关键摘要:

  • generateDevice函数中,如果carddevice都为空,则返回默认值"default"。但在PrepareShutdownSound函数中,cfg.Cardcfg.Device可能为空,但仍然尝试进行格式化,这可能导致运行时错误。
  • PrepareShutdownSound函数中,shutdownCfg.CanPlay被设置为true,但没有相应的注释说明为什么这样做,以及这个设置的实际作用。
  • PrepareShutdownSound函数中的shutdownCfg.ThemeshutdownCfg.Event被设置但没有进行任何操作,这可能是不完整的实现。
  • PrepareShutdownSound函数中的shutdownCfg.ThemeshutdownCfg.Event被设置但没有进行任何操作,这可能是不完整的实现。
  • PrepareShutdownSound函数中的shutdownCfg.ThemeshutdownCfg.Event被设置但没有进行任何操作,这可能是不完整的实现。

是否建议立即修改: 是

deepin-ci-robot avatar Jun 20 '24 09:06 deepin-ci-robot

TAG Bot

TAG: 6.0.12 EXISTED: no DISTRIBUTION: unstable

github-actions[bot] avatar Jun 20 '24 09:06 github-actions[bot]

/topic dpidaemon

zsien avatar Jun 20 '24 09:06 zsien

Add topic: dpidaemon successed.

deepin-ci-robot avatar Jun 20 '24 09:06 deepin-ci-robot

/integr-topic dpidaemon

zsien avatar Jun 20 '24 09:06 zsien

Integrated with pr https://github.com/deepin-community/Repository-Integration/pull/1628

deepin-ci-robot avatar Jun 20 '24 09:06 deepin-ci-robot

/topic ddcci-logoutSound-powerBtn

zsien avatar Jun 20 '24 09:06 zsien

Add topic: ddcci-logoutSound-powerBtn successed.

deepin-ci-robot avatar Jun 20 '24 09:06 deepin-ci-robot

/integr-topic ddcci-logoutSound-powerBtn

zsien avatar Jun 20 '24 09:06 zsien

Integrated with pr https://github.com/deepin-community/Repository-Integration/pull/1629

deepin-ci-robot avatar Jun 20 '24 09:06 deepin-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, yixinshark, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Sep 02 '24 06:09 deepin-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, yixinshark, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

deepin-ci-robot avatar Sep 02 '24 06:09 deepin-ci-robot