fiano icon indicating copy to clipboard operation
fiano copied to clipboard

Allow ExtendedSize to be shown in utk JSON

Open AkechiShiro opened this issue 2 years ago • 6 comments

Pull request, allowing ExtendedSize for UEFI to be shown in the JSON output.

This helps to fix this issue fiedka/fiedka#76 but could be useful for others tools as well.

AkechiShiro avatar May 08 '22 20:05 AkechiShiro

Yea, that's it! Could you please rephrase or just remove the comment? Fiano can be used in other tools as well, so it shouldn't suggest any tight coupling. Maybe include something in the commit message rather, along the lines of "This allows for use with other tools".

Thank you! :-)

orangecms avatar May 08 '22 20:05 orangecms

Ah, and finally, run gofmt, the Go formatting tool; its code style is very opinionated, and that's what causes the checks to error. 😅

orangecms avatar May 08 '22 20:05 orangecms

Thanks for your input on this and help, should I also fix some regression tests which are currently failing due to my change?

AkechiShiro avatar May 08 '22 20:05 AkechiShiro

So the failing test is the extract+reassemble test pkg/visitors/extract_test.go.

In a first step, I am improving the output. Insead of printing the entire buffer, I print the position and the respective byte, #382

orangecms avatar May 11 '22 21:05 orangecms

I gave it another try in #383 by just marshalling the plain Size instead, WDYT?

orangecms avatar May 12 '22 00:05 orangecms

If we can get to fix the tests using #383, I'm all down for it, but @GanShun should also give us his thoughts on it, I guess if that changes would be alright in the codebase.

AkechiShiro avatar May 12 '22 12:05 AkechiShiro