linux019

why not to pass to webpack config to use some modern hash function instead of deprecated md4 https://webpack.js.org/configuration/output/#outputhashfunction ?

**No Device Check** doesn't help with google pay as it works locally only on your phone. Google pay sends nonce generated by SafetyNet to google servers and ones can check...

main() calls `LoadBidderInfoFromDisk` https://github.com/prebid/prebid-server/blob/5b11f59bdde56d7b22678efb4b3dfb2da9c62a7f/main.go#L35 Next is creates a HTTP server where a call to auction endpoint triggers `BuildBidderNameHashSet` Yes if new changes will call `SetAliasBidderName` this cached set needs to...

The tasks should implement graceful shutdown mechanism when PBS receives system signal to terminate the process

USD is used by many bidders, or they internally convert non-USD to $. No extra package is needed. The string 'USD' can be defined as a constant in the internal...

I think the algorithm could be improved by using sliding window approach instead of constant speed https://github.com/prebid/prebid-server/blob/fc184a88aaa498b3e42ecdd124632771fe824d10/config/config.go#L987C37-L987C52 The problems with this constant are: - Multiple deployments where one cluster receives...

``` type GPPSIDMultiValue struct { isString bool isSlice bool str string slice []int8 } func (g *GPPSIDMultiValue) UnmarshalJSON(src []byte) error { if len(src) > 2 { if src[0] == '['...

@bretg we don't need third party library, many of them are over complicated. There is a good implementation https://github.com/panjf2000/ants it can be taken as example

``` hooks: enabled: true modules: prebid: ortb2blocking: enabled: false host_execution_plan: endpoints: "/openrtb2/auction": stages: entrypoint: groups: timeout: 100 #ms hook_sequence: bidder_request: groups: timeout: 100 #ms hook_sequence: - module_code: "prebid.ortb2blocking" hook_impl_code: "prebid.ortb2blocking"...

@SyntaxNode I would use build tags to exclude code which cannot be used without native library. Instead of this we have successfully compiled image which has passed all unit tests...