ltp icon indicating copy to clipboard operation
ltp copied to clipboard

readahead02.c fixes

Open metan-ucw opened this issue 2 years ago • 9 comments

There are a couple things that should be fixed in the test:

We run the test with a loop device it will fail with ENOSPC if we pass -s bigger than the loop device, we should at least check if the device is large enough in the test setup.

The test should make use of use tst_parse_filesize() so that we can pass sizes with units e.g. -s 128M.

As we run the test inside a loop device I guess that we can also sync and drop caches just for the device, which should be faster than syncing and dropping the whole system. Possibly we just need to umount it and mount it again.

metan-ucw avatar Sep 16 '22 08:09 metan-ucw

Hi, Could you please tell what are the required configurations and packages for LTP to make all tests get Pass ?

Thank you

indumathiraju avatar Sep 19 '22 11:09 indumathiraju

@indumathiraju this is not really the right place to ask this question, this issue is about bugs in readahead02 test. Question like this are best to be raised on the project mailing list.

metan-ucw avatar Sep 19 '22 14:09 metan-ucw

@indumathiraju , Please check - https://github.com/linux-test-project/ltp#readme LTP mailing list: http://lists.linux.it/listinfo/ltp

Avinesh avatar Sep 20 '22 05:09 Avinesh

https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

coolgw avatar Jan 29 '23 12:01 coolgw

Looks like the patch linked by @coolgw hasn't been merged yet. I'm wondering what was missing. Is there a way to display reviews in patchwork?

Martchus avatar Sep 28 '23 13:09 Martchus

@Martchus you can check v4, v3 etc in patchwork. There has some review comments. such as https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

coolgw avatar Sep 28 '23 13:09 coolgw

you can check v4, v3 etc in patchwork

I've been following your link. However, I'm wondering how one can navigate from one version to another in patchwork? (Or how can one search for patches? I haven't found a search form anywhere.)

There has some review comments.

Ah, so I understand that you're waiting for further feedback here.

Martchus avatar Sep 28 '23 14:09 Martchus

you can check v4, v3 etc in patchwork

I've been following your link. However, I'm wondering how one can navigate from one version to another in patchwork? (Or how can one search for patches? I haven't found a search form anywhere.)

@Martchus Unfortunately patchwork does not connect series together, this functionality would have to be added. There is already ticket for it: https://github.com/getpatchwork/patchwork/issues/506

pevik avatar Sep 29 '23 05:09 pevik

https://patchwork.ozlabs.org/project/ltp/patch/[email protected]/ v5 version rejected.

coolgw avatar May 28 '24 10:05 coolgw