ltp icon indicating copy to clipboard operation
ltp copied to clipboard

For few I/O tests, paths are hardcoded under runtest. Not in uniform to match with TMPDIR

Open chetjain opened this issue 5 years ago • 3 comments

chetjain avatar Jun 05 '20 10:06 chetjain

The lvm runtest files will probably go away see:

http://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

As these have been made obsolete by 45289e4984d321d0c12c11c73e72b8bb5c2f65a9

The rest looks good, but the patches do miss Signed-off-by, see:

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

metan-ucw avatar Jun 12 '20 13:06 metan-ucw

The lvm runtest files will probably go away see:

http://patchwork.ozlabs.org/project/ltp/patch/[email protected]/

As these have been made obsolete by 45289e4

The rest looks good, but the patches do miss Signed-off-by, see:

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

How do I sign-off? Or Should, I raise new pull request?

chetjain avatar Jun 15 '20 14:06 chetjain

You have to add that line at the end of the git commit message. If you configure git user name and email you can pass -s flag to git commit to do that automatically.

metan-ucw avatar Jun 15 '20 14:06 metan-ucw

Most of these test were rewritten meanwhile to properly create temporary directory at the test startup. The only remaining part of this patchset that is still relevant is the fcntl-locktest, feel free to resubmit that patch with correct SIgned-off-by line.

metan-ucw avatar May 12 '23 08:05 metan-ucw