ltp icon indicating copy to clipboard operation
ltp copied to clipboard

Add feof() conformance tests and assertions.xml

Open Rjasuja opened this issue 6 years ago • 10 comments

Adds

  1. assertions.xml
  2. Testcases 1-1.c and 2-1.c

Change-Id: I6b59efd23d53c48efc7ba94e5209520ead1e5b33 Signed-off-by: Venate, Salini [email protected]

Rjasuja avatar Nov 28 '18 09:11 Rjasuja

Please also add a Signed-off-by line in the commit message, e.g., use git commit -s.

ngie-eign avatar Nov 29 '18 01:11 ngie-eign

Updated the commit. @ngie-eign @metan-ucw Please review.

Rjasuja avatar Dec 03 '18 10:12 Rjasuja

Test demands to open the file again for reading what was written before. With tmpfile(), same file cannot be opened after closing. With tmpnam(), it gives a warning saying warning: the use of tmpnam is dangerous, better use mkstemp. I am not sure if it is safe to use.

Rjasuja avatar Dec 04 '18 05:12 Rjasuja

Test demands to open the file again for reading what was written before. With tmpfile(), same file cannot be opened after closing. With tmpnam(), it gives a warning saying warning: the use of tmpnam is dangerous, better use mkstemp. I am not sure if it is safe to use.

Using tmpnam (while not advised in the general purpose case) is totally valid in this case.

ngie-eign avatar Dec 04 '18 08:12 ngie-eign

@ngie-eign Please review

Rjasuja avatar Dec 12 '18 08:12 Rjasuja

@ngie-eign Can we merge this PR.

Rjasuja avatar Jan 07 '19 03:01 Rjasuja

@ngie-eign Build failed here while synchronizing updates-modular repo.

Rjasuja avatar Jan 16 '19 09:01 Rjasuja

@Rjasuja: it’s passing Travis here. Could you please elaborate?

ngie-eign avatar Jan 18 '19 02:01 ngie-eign

There was some error before. but it's passed now.

Rjasuja avatar Jan 18 '19 03:01 Rjasuja

@ngie-eign Please review the updated commit

Rjasuja avatar Feb 07 '19 06:02 Rjasuja