linux-test-project
min_free_kbytes: Fix child exit status check conditions
min_free_kbytes test has badly formed if conditions in mem_tune() for child exit status check. This is causing test to declare as FAILED despite that not being the case. Fix child exit status check conditions.
Signed-off-by: Vipin K Parashar [email protected]
Tested patch. Its working fine. Test output as below:
$ ./runltp -e 20180515
Without fix:
$./runltp -s min_free_kbytes <..snip..>
mem.c:839: INFO: set overcommit_memory to 1 mem.c:839: INFO: set min_free_kbytes to 11580 memfree is 6974720 kB before eatup mem memfree is 15488 kB after eatup mem min_free_kbytes.c:135: FAIL: child unexpectedly failed: 0 mem.c:839: INFO: set min_free_kbytes to 23160 memfree is 7104128 kB before eatup mem memfree is 26560 kB after eatup mem min_free_kbytes.c:135: FAIL: child unexpectedly failed: 0 mem.c:839: INFO: set min_free_kbytes to 145812 memfree is 7101504 kB before eatup mem memfree is 215872 kB after eatup mem min_free_kbytes.c:135: FAIL: child unexpectedly failed: 0 min_free_kbytes.c:81: PASS: min_free_kbytes test pass mem.c:839: INFO: set min_free_kbytes to 11580 mem.c:839: INFO: set overcommit_memory to 0
Summary: passed 1 failed 3 skipped 0 warnings 0
With fix
$./runltp -s min_free_kbytes <..snip..>
mem.c:839: INFO: set overcommit_memory to 1 mem.c:839: INFO: set min_free_kbytes to 145812 memfree is 7071424 kB before eatup mem memfree is 234944 kB after eatup mem New code mem.c:839: INFO: set min_free_kbytes to 291624 memfree is 6969472 kB before eatup mem memfree is 370624 kB after eatup mem New code mem.c:839: INFO: set min_free_kbytes to 145812 memfree is 6923776 kB before eatup mem memfree is 231296 kB after eatup mem New code min_free_kbytes.c:81: PASS: min_free_kbytes test pass mem.c:839: INFO: set min_free_kbytes to 145812 mem.c:839: INFO: set overcommit_memory to 1
Summary: passed 1 failed 0 skipped 0 warnings 0
@wangli5665 Can you also have a look?
Hi Jan, I'm sorry to response so late, since I disabled the github notification before, I cann't recive any message from github.
I will look into this patch, and also enable the notification in settings.
