lcov icon indicating copy to clipboard operation
lcov copied to clipboard

Handle --include and --exclude for inital captures

Open Marc-Aldorasi-Imprivata opened this issue 4 years ago • 1 comments

This resolves issue #84 by changing process_graphfile to call filter_source_files (which handles the --include and --exclude options) instead of only checking if files are external.

Marc-Aldorasi-Imprivata avatar Dec 29 '20 17:12 Marc-Aldorasi-Imprivata

Is there any reason this can't be merged? We'd like to use mainline lcov in our project but are still waiting on this to make it in.

JeremyAgost avatar Jun 17 '22 17:06 JeremyAgost

FWIW: I had implemented something like this - but added it as an option to genhtml, geninfo, and lcov (i.e., you can use it everywhere). Also added an option to do regexp substitution on filenames at the same time (man pages explain why this is useful - but you may be using sed scripts and already know why you want it). The branch contains quite a few other features as well - see PR #86 and the repo mentioned there.

henry2cox avatar Oct 25 '22 10:10 henry2cox

As mentioned above: I think this is included/subsumed by #169 - so this one can be closed once that one is merged.

henry2cox avatar Nov 10 '22 11:11 henry2cox

Now that #169 is merged - could you take a quick look to verify whether your use model is properly supported now or not? Please close the PR if we are good to go - or update the PR and/or open an issue if more needs to be done. Thanks! Henry

henry2cox avatar Nov 17 '22 14:11 henry2cox

We're in the process of testing the fix, however we've been stymied for the moment by https://github.com/linux-test-project/lcov/issues/174. Working on pulling in additional fixes and retesting.

JeremyAgost avatar Nov 28 '22 16:11 JeremyAgost

We've confirmed that we can build with the latest head, although we had to add several arguments to ignore what I assume are new error checks.

JeremyAgost avatar Nov 28 '22 21:11 JeremyAgost

Good to hear. Yes - there are a bunch of new error checks (including checks that the include/exclude patterns successfully applied to something (e.g., they don't appear to contain typos which make them useless). Sounds like you found the controls to ignore or suppress the new checks.

henry2cox avatar Nov 28 '22 21:11 henry2cox

I believe this PR has been subsumed/the desired functionality has been implemented - albeit, in a different way. Closing this PR now.

If there is something missing or something that does not work as expected: please open a new issue and/or a corresponding PR. Henry

henry2cox avatar May 11 '23 14:05 henry2cox