network icon indicating copy to clipboard operation
network copied to clipboard

docs: Add documentation for specifying VLAN ID

Open Precious000 opened this issue 11 months ago • 8 comments

Enhancement Reason: To provide users with clear guidance on how to specify VLAN ID and settings for the "vlan" type, improving usability and clarity in network configuration.

Result: Users can now easily understand and configure VLAN-related settings using the updated documentation, leading to more efficient network setups.

Issue Tracker Tickets (Jira or BZ if any): [#491]

Precious000 avatar Mar 23 '24 23:03 Precious000

Hi @tyll can you please check the changes and accept pr, are there any corrections?

Precious000 avatar Mar 24 '24 00:03 Precious000

vlan_id was already deprecated since 72f7c8ab4dd7d79b2a86bc38ef04382f0705461e, and the nested vlan is preferred.

-    vlan_id: 6
+    vlan:
+      id: 6

liangwen12year avatar Mar 24 '24 19:03 liangwen12year

Do not forget to sign your commit by using git commit -s.

liangwen12year avatar Mar 24 '24 19:03 liangwen12year

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 43.22%. Comparing base (34d1f2d) to head (7168a41). Report is 7 commits behind head on main.

:exclamation: Current head 7168a41 differs from pull request most recent head cfe3b1d

Please upload reports for the commit cfe3b1d to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #685       +/-   ##
===========================================
+ Coverage   20.50%   43.22%   +22.72%     
===========================================
  Files          10       12        +2     
  Lines        1478     3100     +1622     
  Branches      433        0      -433     
===========================================
+ Hits          303     1340     +1037     
- Misses       1174     1760      +586     
+ Partials        1        0        -1     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 25 '24 08:03 codecov[bot]

PR Title lint is failed, type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test, tests] [type-enum], please change the title for the PR to docs: Add documentation for specifying VLAN ID.

liangwen12year avatar Mar 25 '24 18:03 liangwen12year

type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test, tests] [type-enum]

Hi @liangwen12year I just did. Thanks a lot. Is there any more to be corrected, Sir?

Precious000 avatar Mar 25 '24 21:03 Precious000

Hi @liangwen12year can you please checkout what I’ve done? And please accept the pr?

Precious000 avatar Mar 26 '24 16:03 Precious000

Can you rebase the current PR, git pull --rebase upstream main

liangwen12year avatar Apr 02 '24 14:04 liangwen12year

You'll need to rebase the PR on top of the latest main branch. If you aren't sure how to do that, please ask.

richm avatar Jun 10 '24 15:06 richm