kdump icon indicating copy to clipboard operation
kdump copied to clipboard

check mode in ssh target support: "Cat file to register" will fail

Open pcahyna opened this issue 6 years ago • 2 comments

"Create key" should IMO not have check_mode: False, because it changes the managed host, and one should not do that in check mode. The problem then is that "Cat file to register" will fail, so this is not that easy to fix.

Originally posted by @pcahyna in https://github.com/linux-system-roles/kdump/pull/23/review_comment/create

pcahyna avatar Apr 29 '19 13:04 pcahyna

Note that for proper ssh target support one needs #22

pcahyna avatar Apr 29 '19 13:04 pcahyna

On a second thought, should we actually aim to fix such problems? See https://github.com/ansible/molecule/issues/128#issuecomment-245009843 I mean, failures in check mode when the role has not been executed yet without check mode. (If so, we should change the sequence in molecule testing to run "check" before "converge".)

pcahyna avatar Apr 29 '19 14:04 pcahyna