firewall icon indicating copy to clipboard operation
firewall copied to clipboard

feat: support includes for services

Open richm opened this issue 9 months ago • 3 comments

Feature: Allow for includes to be specified for services. Includes are described at https://firewalld.org/documentation/man-pages/firewalld.service.html

Reason: This makes firewalld services more explicit and easier / quicker to read when there are many non-standard ports.

Result: Users can specify other services to include when creating and setting services.

Signed-off-by: Rich Megginson [email protected]

Fixes https://github.com/linux-system-roles/firewall/issues/255

richm avatar Apr 08 '25 21:04 richm

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.56%. Comparing base (2d7c4ba) to head (ebe46b6). Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
library/firewall_lib.py 9.09% 10 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   61.09%   60.56%   -0.54%     
==========================================
  Files           2        2              
  Lines         910      923      +13     
==========================================
+ Hits          556      559       +3     
- Misses        354      364      +10     
Flag Coverage Δ
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 08 '25 21:04 codecov[bot]

[citest]

richm avatar Apr 08 '25 21:04 richm

[citest]

richm avatar Apr 11 '25 20:04 richm