rdma-core icon indicating copy to clipboard operation
rdma-core copied to clipboard

tests: Modify eswitch mode checking

Open EdwardSro opened this issue 3 years ago • 3 comments

The devlink output behavior would be changed by having two outputs for Eswitch modes, which are legacy and switchdev, instead of having three outputs which are None, legacy, and switchdev. So, the legacy mode will be the default mode.

So, the function that checks the Eswitch mode should be adjusted, since it only checks the legacy mode in case the command returns a non zero value, but with the newer devlinks, the command will return zero value for both legacy and switchdev, so there is important to check the value of the output.

EdwardSro avatar Feb 16 '22 15:02 EdwardSro

Do you have kernel commit that supports the claim of "going to be changed"?

Thanks

rleon avatar Feb 16 '22 16:02 rleon

Do you have kernel commit that supports the claim of "going to be changed"?

Thanks

The patch is going to be sent soon to upstream, once it's done I'll point to it. This patch though supports both the current implementation and the new candidate and was sent as a precautionary measurement. But we can wait for the kernel patch, no rush.

EdwardSro avatar Feb 21 '22 17:02 EdwardSro

I see that the kernel patch was accepted.

EdwardSro avatar Jul 26 '22 12:07 EdwardSro

@rleon can we merge this PR?

EdwardSro avatar Oct 26 '22 14:10 EdwardSro

@EdwardSro please rebase it

jgunthorpe avatar Nov 21 '22 18:11 jgunthorpe

A similar change was already merged as part of a different PR. Will close this.

EdwardSro avatar Nov 22 '22 09:11 EdwardSro