perftest icon indicating copy to clipboard operation
perftest copied to clipboard

perftest: support set flow_label list val in GRH with RR method

Open changchengx opened this issue 1 year ago • 6 comments

For different QP, it may need to set different flow_label. Extend the flow_label option to support list val configuration and keep compatibility.

changchengx avatar Aug 22 '24 07:08 changchengx

extend https://github.com/linux-rdma/perftest/pull/224

changchengx avatar Aug 22 '24 07:08 changchengx

@HassanKhadour FYI

changchengx avatar Aug 22 '24 07:08 changchengx

@changchengx, can you please rebase?

sshaulnv avatar Aug 28 '24 10:08 sshaulnv

@sshaulnv Done

changchengx avatar Aug 29 '24 01:08 changchengx

@sshaulnv @HassanKhadour ping

changchengx avatar Sep 03 '24 12:09 changchengx

@changchengx thanks for your contribution, the PR is under review

sshaulnv avatar Sep 05 '24 06:09 sshaulnv

Hi @changchengx , im getting the following errors when trying to compile:

 src/perftest_parameters.c: In function ‘parser’:
src/perftest_parameters.c:2958:10: warning: implicit declaration of function ‘parse_flow_label_from_str’; did you mean ‘parse_ethertype_from_str’? [-Wimplicit-function-declaration]
      if (parse_flow_label_from_str(user_param, optarg)) {
          ^~~~~~~~~~~~~~~~~~~~~~~~~
          parse_ethertype_from_str
src/perftest_parameters.c: At top level:
src/perftest_parameters.c:3356:12: error: static declaration of ‘parse_flow_label_from_str’ follows non-static declaration
 static int parse_flow_label_from_str(struct perftest_parameters *user_param, char *flow_label_str)
            ^~~~~~~~~~~~~~~~~~~~~~~~~
src/perftest_parameters.c:2958:10: note: previous implicit declaration of ‘parse_flow_label_from_str’ was here
      if (parse_flow_label_from_str(user_param, optarg)) {
          ^~~~~~~~~~~~~~~~~~~~~~~~~
src/perftest_parameters.c:3356:12: warning: ‘parse_flow_label_from_str’ defined but not used [-Wunused-function]
 static int parse_flow_label_from_str(struct perftest_parameters *user_param, char *flow_label_str)
            ^~~~~~~~~~~~~~~~~~~~~~~~~

please fix it, and also update man page.

Thanks

sshaulnv avatar Nov 10 '24 09:11 sshaulnv

@sshaulnv Thanks for your check. I've updated the commit according to your feedback and requirement. If you still hit some problem, please let me know the build environment: OS version & gcc version

changchengx avatar Nov 11 '24 01:11 changchengx

Merged, thanks for your contribution!

sshaulnv avatar Jan 06 '25 05:01 sshaulnv